Re: Fix compilation failure against LLVM 11

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jesse Zhang <sbjesse(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix compilation failure against LLVM 11
Date: 2020-05-28 08:07:46
Message-ID: 20200528080746.GC44192@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 27, 2020 at 07:49:45AM -0700, Jesse Zhang wrote:
> For bystanders: Andres and I argued for "fixing this sooner and
> backpatch" and Michael suggested "wait longer and whack all moles". We
> have waited, and there seems to be only one mole (finding all dead
> unbroken "include"s was left as an exercise for the reader). Have we
> come to an agreement on this?

If Andres could take care of this issue as he feels is suited, that's
OK for me. I could look at that and play with llvm builds. Now I am
not really familiar with it, so it would take me some time but we are
all here to learn :)

Please note that I would still wait for their next GA release to plug
in any extra holes at the same time. @Jesse: or is this change
actually part of the upcoming 10.0.1?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-05-28 08:09:25 Re: max_slot_wal_keep_size comment in postgresql.conf
Previous Message Kyotaro Horiguchi 2020-05-28 08:04:36 Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762