| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | jeff(dot)janes(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: max_slot_wal_keep_size comment in postgresql.conf |
| Date: | 2020-05-27 01:46:27 |
| Message-ID: | 20200527.104627.1384873106222413598.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Tue, 26 May 2020 09:10:40 -0400, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote in
> In postgresql.conf, it says:
>
> #max_slot_wal_keep_size = -1 # measured in bytes; -1 disables
>
> I don't know if that is describing the dimension of this parameter or the
> units of it, but the default units for it are megabytes, not individual
> bytes, so I think it is pretty confusing.
Agreed. It should be a leftover at the time the unit was changed
(before committed) to MB from bytes. The default value makes the
confusion worse.
Is the following works?
#max_slot_wal_keep_size = -1 # in MB; -1 disables
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Change-a-comment-in-postgresql.conf.sample.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-05-27 01:46:54 | Re: hash join error improvement (old) |
| Previous Message | Melanie Plageman | 2020-05-27 01:42:50 | Re: Trouble with hashagg spill I/O pattern and costing |