| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: hash join error improvement (old) |
| Date: | 2020-05-26 19:17:10 |
| Message-ID: | 20200526191710.GA19482@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-May-26, Tom Lane wrote:
> Digging further down, it looks like BufFileWrite calls BufFileDumpBuffer
> which calls FileWrite which takes pains to set errno correctly after a
> short write --- so other than the lack of commentary about these
> functions' error-reporting API, I don't think there's any actual bug here.
Doh, you're right, this patch is completely broken ... aside from
carelessly writing the wrong "if" test, my unfamiliarity with the stdio
fread/fwrite interface is showing. I'll look more carefully.
> Are you sure you correctly identified the source of the bogus error
> report?
Nope. And I wish the bogus error report was all there was to it. The
actual problem is a server crash.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bossart, Nathan | 2020-05-26 19:30:54 | Re: race condition when writing pg_control |
| Previous Message | Tomas Vondra | 2020-05-26 19:15:11 | Re: Trouble with hashagg spill I/O pattern and costing |