| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | alvherre(at)2ndquadrant(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove page-read callback from XLogReaderState. |
| Date: | 2020-05-26 07:40:02 |
| Message-ID: | 20200526.164002.822446651247617415.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 22 Apr 2020 10:12:46 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> cd12323440 conflicts with this. Rebased.
b060dbe000 is conflicting. I gave up isolating XLogOpenSegment from
xlogreader.c, since the two are tightly coupled than I thought.
This patch removes all the three callbacks (open/close/page_read) in
XL_ROUTINE from XLogReaderState. It only has "cleanup" callback
instead.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Move-callback-call-from-ReadPageInternal-to-XLog.patch | text/x-patch | 25.2 KB |
| v10-0002-Move-page-reader-out-of-XLogReadRecord.patch | text/x-patch | 66.7 KB |
| v10-0003-Remove-globals-readOff-readLen-and-readSegNo.patch | text/x-patch | 8.6 KB |
| v10-0004-Change-policy-of-XLog-read-buffer-allocation.patch | text/x-patch | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2020-05-26 07:43:34 | Re: SyncRepGetSyncStandbysPriority() vs. SIGHUP |
| Previous Message | Konstantin Knizhnik | 2020-05-26 07:17:24 | Re: New Feature Request |