Re: Potentially misleading name of libpq pass phrase hook

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Potentially misleading name of libpq pass phrase hook
Date: 2020-05-16 01:56:21
Message-ID: 20200516015621.GF212736@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote:
> +1 on all of the above.
>
> I noticed this has been added to Open Items; I added a note that the
> plan is to fix before the Beta 1 wrap.

+1. Thanks.

Agreed. PQsslKeyPassHook_<library>_type sounds fine to me as
convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and
PQgetSSLKeyPassHook, appending an "_OpenSSL" to both?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-05-16 03:06:34 Re: calling procedures is slow and consumes extra much memory against calling function
Previous Message Tom Lane 2020-05-16 01:54:51 Re: PostgreSQL 13 Beta 1 Release: 2020-05-21