Re: Add "-Wimplicit-fallthrough" to default flags

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: zhihui(dot)fan1213(at)gmail(dot)com
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, alvherre(at)2ndquadrant(dot)com, rjuju123(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add "-Wimplicit-fallthrough" to default flags
Date: 2020-05-13 10:15:58
Message-ID: 20200513.191558.2288750702883807998.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

At Wed, 13 May 2020 16:17:50 +0800, Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> wrote in
> On Wed, May 13, 2020 at 4:13 PM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
> wrote:
> > > jsonpath_gram.c:1026:16: warning: this statement may fall through
> > [-Wimplicit-fallthrough=]
> > > if (*++yyp != '\\')
> > > ^
> > > jsonpath_gram.c:1029:11: note: here
> > > default:
...
> > It is generated code by bison.
> >
> > $ bison --version
> > bison (GNU Bison) 3.0.4
> >
> >
> I just found this just serval minutes ago. Upgrading your bison to the
> latest
> version (3.6) is ok. I'd like we have a better way to share this knowledge
> through.
> I spend ~30 minutes to troubleshooting this issue.

Thanks. I'm happy to know that! But AFAICS 3.0.4 is the current
version of bison in AppStream and PowerTools of CentOS8...

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Julien Rouhaud 2020-05-13 11:35:18 Re: Add "-Wimplicit-fallthrough" to default flags
Previous Message Andy Fan 2020-05-13 08:17:50 Re: Add "-Wimplicit-fallthrough" to default flags

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-05-13 11:20:36 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Dilip Kumar 2020-05-13 09:07:21 Re: Index Skip Scan