| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: stat() on Windows might cause error if target file is larger than 4GB |
| Date: | 2020-05-09 00:49:20 |
| Message-ID: | 20200509004920.GA4395@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Sep-13, Tom Lane wrote:
> What I was vaguely imagining is that win32_port.h could #include
> whichever Windows header defines these functions and structs, and
> then do
>
> #define stat __stat64
>
> static inline ... __stat64(...) { return _stat64(...); }
>
> What would need testing is whether the #define has nasty side-effects
> even if we've already included the system header. I don't think it'd
> hurt, eg, local variables named "stat"; though people might be surprised
> when examining things in a debugger.
Did anybody test this idea? It seems we let this problem slip unfixed,
which means Windows users cannot use pg_dump -Fd (incl. parallel dump)
when output files are large.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2020-05-09 01:58:10 | Re: Avoiding hash join batch explosions with extreme skew and weird stats |
| Previous Message | Andres Freund | 2020-05-09 00:26:49 | Re: Include sequence relation support in logical replication |