| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_restore error message |
| Date: | 2020-05-08 23:45:16 |
| Message-ID: | 20200508234516.GA13259@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-May-07, Ranier Vilela wrote:
> Can suggest improvements?
>
> 1. free (398 line) must be pg_free(buf)';
Yeah, there's a lot of frontend code that uses free() instead of
pg_free(). There are too many of these that worrying about a single one
would not improve things much. I guess we could convert them all, but I
don't see much point.
> 2. %m, is a format to parameter, right?
> But what parameter? Both fatal call, do not pass this parameter, or is
> it implied?
%m is an implied "strerror(errno)", implemented by our snprintf
replacement.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-05-08 23:53:13 | Re: pendingOps table is not cleared with fsync=off |
| Previous Message | Alvaro Herrera | 2020-05-08 23:42:30 | Re: pg_restore error message |