Re: Remove unnecessary relabel stripping

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unnecessary relabel stripping
Date: 2020-04-30 00:11:02
Message-ID: 20200430001102.nue4khm546sbjg2v@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 29, 2020 at 03:51:40PM +0800, Richard Guo wrote:
>Hi hackers,
>
>Per discussion in [1], we don't need to strip relabel for the expr
>explicitly before calling pull_varnos() to retrieve all mentioned
>relids. pull_varnos() would recurse into T_RelabelType nodes.
>
>Add a patch to remove that and simplify the code a bit.
>
>[1]
>https://www.postgresql.org/message-id/flat/CAMbWs48HF9f%3Dg%2BjSmmYBnWub9%2BWyg5Xh-FoqAnvqAspue5ypAw%40mail.gmail.com#b6e77e4c1ae67e2c5d97dce830b58037
>
>Thanks
>Richard

Thanks, I'll get this pushed (or something similar to this patch) soon.

FWIW it'd be better to send the patch to the original thread instead of
starting a new one.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-04-30 00:15:27 Re: Poll: are people okay with function/operator table redesign?
Previous Message Peter Geoghegan 2020-04-29 23:58:34 Re: xid wraparound danger due to INDEX_CLEANUP false