| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | jgdr(at)dalibo(dot)com, andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, sawada(dot)mshk(at)gmail(dot)com, peter(dot)eisentraut(at)2ndquadrant(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, thomas(dot)munro(at)enterprisedb(dot)com, sk(at)zsrv(dot)org, michael(dot)paquier(at)gmail(dot)com |
| Subject: | Re: [HACKERS] Restricting maximum keep segments by repslots |
| Date: | 2020-04-27 23:40:07 |
| Message-ID: | 20200427234007.GA14631@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Apr-08, Kyotaro Horiguchi wrote:
> I understand how it happens.
>
> The latch triggered by checkpoint request by CHECKPOINT command has
> been absorbed by ConditionVariableSleep() in
> InvalidateObsoleteReplicationSlots. The attached allows checkpointer
> use MyLatch for other than checkpoint request while a checkpoint is
> running.
Hmm, that explanation makes sense, but I couldn't reproduce it with the
steps you provided. Perhaps I'm missing something.
Anyway I think this patch should fix it also -- instead of adding a new
flag, we just rely on the existing flags (since do_checkpoint must have
been set correctly from the flags earlier in that block.)
I think it'd be worth to verify this bugfix in a new test. Would you
have time to produce that? I could try in a couple of days ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-freeze-on-checkpoints.patch | text/x-diff | 843 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2020-04-27 23:58:47 | Re: [BUG] non archived WAL removed during production crash recovery |
| Previous Message | Michael Paquier | 2020-04-27 23:01:38 | Re: [BUG] non archived WAL removed during production crash recovery |