From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: [BUG] non archived WAL removed during production crash recovery |
Date: | 2020-04-22 23:46:18 |
Message-ID: | 20200422234618.GI33034@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wed, Apr 22, 2020 at 06:17:17PM +0200, Jehan-Guillaume de Rorthais wrote:
> I found an extra useless line of code in v9 patch. Please, find in
> attachment v10. Sorry for this.
Thanks for helping here, your changes make sense. This looks mostly
fine to me except that part:
+$standby1->poll_query_until('postgres',
+ qq{ SELECT pg_xlog_location_diff('$primary_lsn', pg_last_xlog_replay_location()) = 0 })
+ or die "Timed out while waiting for xlog replay";
Here we should check if $primary_lsn is at least
pg_last_xlog_replay_location(). Checking for an equality may stuck
the test if more WAL gets replayed. For example you could have a
concurrent autovacuum generating WAL.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-04-23 03:00:07 | Re: BUG #16112: large, unexpected memory consumption |
Previous Message | PG Bug reporting form | 2020-04-22 22:28:04 | BUG #16384: having trouble while installation |
From | Date | Subject | |
---|---|---|---|
Next Message | Jesse Zhang | 2020-04-23 00:12:14 | Re: Header / Trailer Comment Typos for M4 macros |
Previous Message | Tom Lane | 2020-04-22 23:39:09 | Re: Parallel Append can break run-time partition pruning |