Re: cleaning perl code

From: "Hamlin, Garick L" <ghamlin(at)isc(dot)upenn(dot)edu>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: cleaning perl code
Date: 2020-04-16 14:20:53
Message-ID: 20200416142052.zqtgtiubaf6fycn2@isc.upenn.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 16, 2020 at 08:50:35AM -0400, Andrew Dunstan wrote:
>
> It would also be more robust using non-greedy matching:

This seems more important.
I don't know how/where this is being used, but if it has input like:

/* one */
something;
/* two */

With the old expression 'something;' would be stripped away.
Is that an issue where this this is used? Why are we parsing
these headers?

Garick

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2020-04-16 14:34:39 Re: cleaning perl code
Previous Message Justin Pryzby 2020-04-16 14:19:11 Re: Autovacuum on partitioned table (autoanalyze)