Re: pgsql: Allow users to limit storage reserved by replication slots

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: pgsql: Allow users to limit storage reserved by replication slots
Date: 2020-04-08 02:36:02
Message-ID: 20200408023602.GF1606@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Apr 07, 2020 at 07:10:07PM -0700, Andres Freund wrote:
> I have not looked at the source, but the error messages show LSNs
> and bytes. I can't really imagine how that could be made stable.

Another bad news is that this is page-size dependent. What if you
removed pg_size_pretty() and replaced it with a condition that returns
a boolean status in the result itself?
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2020-04-08 02:58:37 pgsql: Support PrefetchBuffer() in recovery.
Previous Message Michael Paquier 2020-04-08 02:18:01 Re: pgsql: Implement waiting for given lsn at transaction start

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2020-04-08 02:37:45 Re: d25ea01275 and partitionwise join
Previous Message Michael Paquier 2020-04-08 02:32:10 Re: implicit declaration of datumIsEqual in parse_coerce.c