Re: [BUG] non archived WAL removed during production crash recovery

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: [BUG] non archived WAL removed during production crash recovery
Date: 2020-04-08 02:23:45
Message-ID: 20200408022345.GC1606@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Apr 07, 2020 at 05:17:36PM +0200, Jehan-Guillaume de Rorthais wrote:
> I'm not sure who would need this information before the WAL machinery is up,
> but is it safe enough in your opinion for futur usage of GetRecoveryState()? Do
> you think this information might be useful before the WAL machinery is set?
> Current "user" (eg. restoreTwoPhaseData()) only need to know if we are in
> recovery, whatever the reason.

(I had this thread marked as something to look at, but could not.
Sorry for the delay).

> src/test/recovery/t/011_crash_recovery.pl | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/src/test/recovery/t/011_crash_recovery.pl b/src/test/recovery/t/011_crash_recovery.pl
> index ca6e92b50d..ce2e899891 100644
> --- a/src/test/recovery/t/011_crash_recovery.pl
> +++ b/src/test/recovery/t/011_crash_recovery.pl
> @@ -15,11 +15,17 @@ if ($Config{osname} eq 'MSWin32')

May I ask why this new test is added to 011_crash_recovery.pl which is
aimed at testing crash and redo, while we have 002_archiving.pl that
is dedicated to archiving in a more general manner?
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2020-04-08 06:06:39 Re: BUG #16325: Assert failure on partitioning by int for a text value with a collation
Previous Message PG Bug reporting form 2020-04-08 01:24:28 BUG #16349: pgbouncer missing from repo

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-04-08 02:32:10 Re: implicit declaration of datumIsEqual in parse_coerce.c
Previous Message Tom Lane 2020-04-08 02:17:01 Re: d25ea01275 and partitionwise join