Re: [PATCH] Incremental sort (was: PoC: Partial sort)

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: 2020-04-06 22:44:34
Message-ID: 20200406224434.xwkq5cqgo6g2n4gl@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 06, 2020 at 06:34:04PM -0400, Tom Lane wrote:
>Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>> On Mon, Apr 06, 2020 at 05:51:43PM -0400, Tom Lane wrote:
>>> Well, it's *less* unhappy. thorntail is showing that the number of
>>> workers field is not stable; that will need to be masked.
>
>> Yeah, I've already pushed a fix for that. But there seems to be another
>> failure in th explain output. Looking.
>
>I'm kind of unimpressed with that fix, because it guarantees that if
>there's any problem with more than 2 workers, this test will never
>find it. I think you should do what I said and arrange to replace
>the number-of-workers output with "N".
>

I can do that, but isn't this how every other regression test does it?

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-04-06 23:09:11 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Tom Lane 2020-04-06 22:34:04 Re: [PATCH] Incremental sort (was: PoC: Partial sort)