Re: Consider low startup cost in add_partial_path

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: James Coleman <jtc331(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Consider low startup cost in add_partial_path
Date: 2020-04-05 14:14:49
Message-ID: 20200405141449.phonf2dicgrnqyns@development
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

For the record, here is the relevant part of the Incremental Sort patch
series, updating add_partial_path and add_partial_path_precheck to also
consider startup cost.

The changes in the first two patches are pretty straight-forward, plus
there's a proposed optimization in the precheck function to only run
compare_pathkeys if entirely necessary. I'm currently evaluating those
changes and I'll post the results to the incremental sort thread.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v54-0001-Consider-low-startup-cost-when-adding-partial-path.patch text/plain 4.6 KB
v54-0002-rework-add_partial_path_precheck-too.patch text/plain 5.2 KB
v54-0003-rework-add_partial_path_precheck-check-costs-first.patch text/plain 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2020-04-05 15:29:15 Re: WIP: BRIN multi-range indexes
Previous Message Tomas Vondra 2020-04-05 13:12:27 Re: [PATCH] Incremental sort (was: PoC: Partial sort)