Re: Rethinking opclass member checks and dependency strength

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Rethinking opclass member checks and dependency strength
Date: 2020-03-31 21:09:49
Message-ID: 20200331210949.GA7342@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Aug-18, Tom Lane wrote:

> * I'm not at all impressed with the name, location, or concept of
> opfam_internal.h. I think we should get rid of that header and put
> the OpFamilyMember struct somewhere else. Given that this patch
> makes it part of the AM API, it wouldn't be unreasonable to move it
> to amapi.h. But I've not done that here.

I created that file so that it'd be possible to interpret the struct
when dealing with DDL commands in event triggers (commit b488c580aef4).
The struct was previously in a .c file, and we didn't have an
appropriate .h file to put it in. I think amapi.h is a great place for

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-31 21:16:39 Re: Berserk Autovacuum (let's save next Mandrill)
Previous Message Alvaro Herrera 2020-03-31 21:01:36 Re: [HACKERS] Restricting maximum keep segments by repslots