Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alexey Bashtanov <bashtanov(at)imap(dot)cc>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small docs bugfix: make it clear what can be used in UPDATE FROM and DELETE USING
Date: 2020-03-31 20:32:07
Message-ID: 20200331203207.GB17676@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 18, 2020 at 12:24:45PM -0400, Bruce Momjian wrote:
> On Tue, Mar 17, 2020 at 10:58:54PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > I have implemented the ideas above in the attached patch. I have
> > > synchronized the syntax to match SELECT, and synchronized the paragraphs
> > > describing the item.
> >
> > I think that the DELETE synopsis should look like
> >
> > [ USING <replaceable class="parameter">from_item</replaceable> [, ...] ]
> >
> > so that there's not any question which part of the SELECT syntax we're
> > talking about. I also think that the running text in both cases should
> > say in exactly these words "from_item means the same thing as it does
> > in SELECT"; the wording you propose still seems to be dancing around
> > the point, leaving readers perhaps not quite sure about what is meant.
> >
> > In the DELETE case you could alternatively say "using_item means the same
> > thing as from_item does in SELECT", but that doesn't really seem like an
> > improvement to me.
>
> OK, updated patch attached.

Patch appied through 9.5.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EnterpriseDB https://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-31 20:45:50 Re: Rethinking opclass member checks and dependency strength
Previous Message Dean Rasheed 2020-03-31 20:23:35 Re: Berserk Autovacuum (let's save next Mandrill)