Re: color by default

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: color by default
Date: 2020-03-30 08:03:46
Message-ID: 20200330080346.GF43995@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 29, 2020 at 02:55:37PM +0200, Juan José Santamaría Flecha wrote:
> Add it to the tests done when PG_COLOR is "auto".

FWIW, I am not sure that it is a good idea to stick into the code
knowledge inherent to TERM. That would likely rot depending on how
terminals evolve in the future, and it is easy to test if a terminal
supports color or not but just switching PG_COLOR in a given
environment and look at the error message produced by anything
able to support coloring.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-03-30 08:03:59 Re: Planning counters in pg_stat_statements (using pgss_store)
Previous Message Julien Rouhaud 2020-03-30 08:00:05 Re: pg_stat_statements issue with parallel maintenance (Was Re: WAL usage calculation patch)