| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Define variables in the approprieate scope |
| Date: | 2020-03-24 01:04:24 |
| Message-ID: | 20200324010424.GA1836@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 23, 2020 at 08:50:55PM -0400, Bruce Momjian wrote:
> On Mon, Mar 23, 2020 at 01:00:24PM -0300, Alvaro Herrera wrote:
>> If we're talking about personal preference, my own is what Antonin
>> shows. However, since disagreement has been expressed, I think we
>> should only change it if the generated code turns out better.
>
> I am fine with either usage, frankly. I was just pointing out what
> might be the benefit of the current coding.
Personal opinion here. I tend to prefer putting variable declarations
into the inner portions because it makes it easier to reason about the
code, though I agree that this concept does not need to be applied all
the time.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-03-24 01:08:38 | Re: Additional improvements to extended statistics |
| Previous Message | Bruce Momjian | 2020-03-24 00:50:55 | Re: Define variables in the approprieate scope |