| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: error context for vacuum to include block number |
| Date: | 2020-03-21 08:03:19 |
| Message-ID: | 20200321080319.GF13662@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 21, 2020 at 01:00:03PM +0530, Amit Kapila wrote:
> I have addressed your comments in the attached patch. Today, while
> testing error messages from various phases, I noticed that the patch
> fails to display error context if the error occurs during the truncate
> phase. The reason was that we had popped the error stack in
> lazy_scan_heap due to which it never calls the callback. I think we
> need to set up callback at a higher level as is done in the attached
> patch. I have done the testing by inducing errors in various phases
> and it prints the required information. Let me know what you think of
> the attached?
Thanks. My tests with TRUNCATE were probably back when we had multiple
push/pop cycles of local error callbacks.
This passes my tests.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2020-03-21 10:07:35 | Re: SQL/JSON: functions |
| Previous Message | Amit Kapila | 2020-03-21 07:30:03 | Re: error context for vacuum to include block number |