Why does [auto-]vacuum delay not report a wait event?

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Why does [auto-]vacuum delay not report a wait event?
Date: 2020-03-19 22:44:49
Message-ID: 20200319224449.pbjrivflbf4x76tj@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I was looking at [1], wanting to suggest a query to monitor what
autovacuum is mostly waiting on. Partially to figure out whether it's
mostly autovacuum cost limiting.

But uh, unfortunately the vacuum delay code just sleeps without setting
a wait event:

/* Nap if appropriate */
if (msec > 0)
if (msec > VacuumCostDelay * 4)
msec = VacuumCostDelay * 4;

pg_usleep((long) (msec * 1000));

Seems like it should instead use a new wait event in the PG_WAIT_TIMEOUT

Given how frequently we run into trouble with [auto]vacuum throttling
being a problem, and there not being any way to monitor that currently,
that seems like it'd be a significant improvement, given the effort?

It'd probably also be helpful to report the total time [auto]vacuum
spent being delayed for vacuum verbose/autovacuum logging, but imo
that'd be a parallel feature to a wait event, not a replacement.


Andres Freund

[1] https://postgr.es/m/CAE39h22zPLrkH17GrkDgAYL3kbjvySYD1io%2BrtnAUFnaJJVS4g%40mail.gmail.com


Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2020-03-19 22:57:21 Re: SQL/JSON: functions
Previous Message Andres Freund 2020-03-19 22:27:11 Re: Berserk Autovacuum (let's save next Mandrill)