| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: pgsql: walreceiver uses a temporary replication slot by default |
| Date: | 2020-03-19 02:26:17 |
| Message-ID: | 20200319022617.GP214947@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Mar 17, 2020 at 11:39:11PM +0300, Sergei Kornilov wrote:
> We need this change to set is_temp_slot properly. PrimarySlotName
> GUC can usually be an empty string, so just "slotname != NULL" is
> not enough.
Yep, or a temporary slot would never be created even if there is no
slot defined, and the priority goes to primary_slot_name if set.
> I attached patch with this change.
Thanks, I have added a new open item for v13 to track this effort:
https://wiki.postgresql.org/wiki/PostgreSQL_13_Open_Items
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-03-19 02:53:20 | pgsql: Add assert to ensure that page locks don't participate in deadlo |
| Previous Message | Peter Geoghegan | 2020-03-19 01:17:59 | pgsql: nbtree: Use raw PageAddItem() for retail inserts. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-03-19 02:32:37 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Previous Message | Alvaro Herrera | 2020-03-19 02:24:26 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |