Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Date: 2020-03-17 03:14:27
Message-ID: 20200317031427.GU26184@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 16, 2020 at 07:17:36PM -0300, Alvaro Herrera wrote:
> I pushed 0001 and 0003 (as a single commit). archive_statusdir didn't
> get here until 12, so your commit message was mistaken. Also, pg10 is
> slightly different so it didn't apply there, so I left it alone.

Thanks, I appreciate it (and I'm sure Fabien will appreciate having two fewer
patches...).

@cfbot: rebased onto b4570d33aa045df330bb325ba8a2cbf02266a555

I realized that if I lstat() a file to make sure links to dirs show as
isdir=false, it's odd to then show size and timestamps of the dir. So changed
to use lstat ... and squished.

--
Justin

Attachment Content-Type Size
v13-0001-Document-historic-behavior-of-links-to-directori.patch text/x-diff 1.1 KB
v13-0002-Add-tests-exercising-pg_ls_tmpdir.patch text/x-diff 4.3 KB
v13-0003-Add-pg_ls_dir_metadata-to-list-a-dir-with-file-m.patch text/x-diff 14.3 KB
v13-0004-pg_ls_tmpdir-to-show-isdir-argument.patch text/x-diff 7.3 KB
v13-0005-pg_ls_-dir-to-show-directories-and-isdir-column.patch text/x-diff 10.2 KB
v13-0006-Add-pg_ls_dir_recurse-to-show-dir-recursively.patch text/x-diff 6.1 KB
v13-0007-pg_ls_logdir-to-ignore-error-if-initial-top-dir-.patch text/x-diff 3.0 KB
v13-0008-pg_ls_-dir-to-return-all-the-metadata-from-pg_st.patch text/x-diff 16.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message yuzuko 2020-03-17 03:22:05 Re: Autovacuum on partitioned table
Previous Message Fujii Masao 2020-03-17 03:07:29 Re: comments on elements of xlogctldata