| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ALTER tbl rewrite loses CLUSTER ON index |
| Date: | 2020-03-16 13:27:31 |
| Message-ID: | 20200316132731.GJ26184@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 16, 2020 at 04:01:42PM +0900, Amit Langote wrote:
> I came across a commit that recently went in:
>
> commit 1cc9c2412cc9a2fbe6a381170097d315fd40ccca
> Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> Date: Fri Mar 13 11:28:11 2020 +0100
>
> Preserve replica identity index across ALTER TABLE rewrite
>
> which fixes something very similar to what we are trying to with this
> patch. The way it's done looks to me very close to what you are
> telling. I have updated the patch to be similar to the above fix.
Yes, I noticed it too.
Should we use your get_index_isclustered more widely ?
Also, should we call it "is_index_clustered", since otherwise it sounds alot
like "+get_index_clustered" (without "is"), which sounds like it takes a table
and returns which index is clustered. That might be just as useful for some of
these callers.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-ALTER-tbl-rewrite-loses-CLUSTER-ON-index.patch | text/x-diff | 9.4 KB |
| v7-0002-Use-get_index_isclustered-in-cluster.c.patch | text/x-diff | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2020-03-16 13:34:57 | Re: VACUUM memory management |
| Previous Message | David Steele | 2020-03-16 13:23:45 | Re: Libpq support to connect to standby server as priority |