Re: Refactor compile-time assertion checks for C/C++

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Georgios Kokolatos <gkokolatos(at)pm(dot)me>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor compile-time assertion checks for C/C++
Date: 2020-03-11 23:43:42
Message-ID: 20200311234342.GB102315@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 11, 2020 at 12:31:19PM +0000, Georgios Kokolatos wrote:
> For whatever is worth, my previous comment that the patch improves
> readability also applies to the updated version of the patch.

v2 has actually less diffs for the C++ part.

> The CF bot seems happy now, which means that your assessment as
> to the error and fix are correct.

Indeed the bot is happy now. By looking at the patch, one would note
that what it just does is unifying the fallback "hack-ish"
implementations so as C and C++ use the same thing, which is the
fallback implementation for C of HEAD. I would prefer hear first from
more people to see if they like this change. Or not.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Devrim Gündüz 2020-03-12 00:09:05 Re: v13 latest snapshot build error
Previous Message David Rowley 2020-03-11 23:42:25 Re: Use compiler intrinsics for bit ops in hash