Re: [PATCH] Skip llvm bytecode generation if LLVM is missing

From: Andres Freund <andres(at)anarazel(dot)de>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Devrim Gündüz <devrim(at)gunduz(dot)org>
Subject: Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Date: 2020-03-11 19:43:22
Message-ID: 20200311194322.a6t6h26k4frznneq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2020-03-11 11:25:28 +0800, Craig Ringer wrote:
> I propose that per the attached patch PGXS should simply skip adding
> the automatic dependency for .bc files if clang cannot be found.
> Extensions may still choose to explicitly declare the rule in their
> own Makefile if they want to force bitcode generation.

Hm, that seems like it could also cause silent failures (e.g. after a
package upgrade or such).

How about erroring out, but with an instruction that llvm can be
disabled with make NO_LLVM=1 or such?

Regards,

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-11 19:44:55 Re: v13 latest snapshot build error
Previous Message Peter Eisentraut 2020-03-11 19:34:34 Re: Improve handling of parameter differences in physical replication