| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-03-06 08:22:16 |
| Message-ID: | 20200306082216.GA173911@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 05, 2020 at 11:09:06PM -0300, Alvaro Herrera wrote:
> Hmm, doesn't the CF bot already validate the MSVC build?
>
> Splitting in two seems all right, but I think one commit that introduces
> dead code is not great. It may make more sense to have one commit for
> common/archive.c, and a second commit that does fe_archive plus
> pg_rewind changes ... If that doesn't work for whatever reason, then
> doing a single commit may be preferrable.
Thanks for the suggestion. Avoiding dead code makes sense as well
here. I'll think about this stuff a bit more first.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | asaba.takanori@fujitsu.com | 2020-03-06 08:30:03 | RE: Conflict handling for COPY FROM |
| Previous Message | Pavel Stehule | 2020-03-06 08:16:59 | Re: SQL/JSON: functions |