| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | rjuju123(at)gmail(dot)com |
| Cc: | peter(dot)eisentraut(at)2ndquadrant(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, magnus(at)hagander(dot)net, noriyoshi(dot)shinoda(at)hpe(dot)com, amitlangote09(at)gmail(dot)com, masahiko(dot)sawada(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |
| Date: | 2020-03-05 09:41:02 |
| Message-ID: | 20200305.184102.1640064023845635564.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 5 Mar 2020 10:32:45 +0100, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote in
> On Thu, Mar 5, 2020 at 8:15 AM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> >
> > On 2020-03-05 05:53, Fujii Masao wrote:
> > > Or, as another approach, it might be worth considering to make
> > > the server always estimate the total backup size whether --progress is
> > > specified or not, as Amit argued upthread. If the time required to
> > > estimate the backup size is negligible compared to total backup time,
> > > IMO this approach seems better. If we adopt this, we can also get
> > > rid of PROGESS option from BASE_BACKUP replication command.
> >
> > I think that would be preferable.
>
> +1
+1
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2020-03-05 10:10:46 | Re: backup manifests |
| Previous Message | Daniel Gustafsson | 2020-03-05 09:38:38 | Re: Change atoi to strtol in same place |