Re: [HACKERS] [PATCH] Generic type subscripting

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: 2020-03-04 17:03:39
Message-ID: 20200304170339.g4xgydtxtmgfajbe@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Tue, Mar 03, 2020 at 12:55:38PM -0500, David Steele wrote:
> > Yep, I wasn't paying much attention recently to this patch, will post
> > rebased and fixed version soon.
> The last CF for PG13 has begun. Do you know when you'll have a rebased and
> updated patch available? The current patch no longer applies.

Thanks for the reminder! Here is the rebased version, with one extra
detail. Looks like tests for non-strict version of jsonb_set are doing:

\pset null NULL

and backwards, but via:

\pset null

which is not changing it back. It's showed up in tests for subscripting
down the file, so I've changed it to what I guess it was suppose to be:

\pset null ''

Attachment Content-Type Size
v30-0001-Base-implementation-of-subscripting-mechanism.patch text/x-diff 47.4 KB
v30-0002-Subscripting-for-array.patch text/x-diff 24.8 KB
v30-0003-Subscripting-for-jsonb.patch text/x-diff 34.1 KB
v30-0004-Subscripting-documentation.patch text/x-diff 20.0 KB
v30-0005-Polymorphic-subscripting.patch text/x-diff 61.6 KB
v30-0006-Filling-gaps-in-jsonb-arrays.patch text/x-diff 8.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2020-03-04 17:13:04 Re: Portal->commandTag as an enum
Previous Message Ashutosh Bapat 2020-03-04 16:39:19 Re: Option to dump foreign data in pg_dump