Re: Add LogicalTapeSetExtend() to logtape.c

From: Adam Lee <ali(at)pivotal(dot)io>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Subject: Re: Add LogicalTapeSetExtend() to logtape.c
Date: 2020-03-04 03:57:19
Message-ID: 20200304035719.GB1022@earth.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 03, 2020 at 08:46:24AM -0800, Jeff Davis wrote:
> On Tue, 2020-03-03 at 09:49 +0800, Adam Lee wrote:
> > Master: 12729ms 12970ms 12999ms
> > With my patch(a pointer): 12965ms 13273ms 13116ms
> > With your patch(flexible array): 12906ms 12991ms 13043ms
>
> Hmm.. looks like you didn't reproduce the difference I saw. What
> compiler/version?

It was "Apple clang version 11.0.0 (clang-1100.0.33.17)".

Then I changed to "gcc-9 (Homebrew GCC 9.2.0_3) 9.2.0" this morning.

Master(e537aed61d): 13342.844 ms 13195.982 ms 13271.023 ms
With my patch(a pointer): 13020.029 ms 13008.158 ms 13063.658 ms
With your patch(flexible array): 12870.117 ms 12814.725 ms 13119.255 ms

--
Adam Lee

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2020-03-04 04:13:19 Re: Some problems of recovery conflict wait events
Previous Message Dilip Kumar 2020-03-04 03:43:49 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions