|From:||David Fetter <david(at)fetter(dot)org>|
|To:||Jesse Zhang <sbjesse(at)gmail(dot)com>|
|Cc:||PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Use compiler intrinsics for bit ops in hash|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Wed, Feb 26, 2020 at 09:12:24AM +0100, David Fetter wrote:
> On Fri, Jan 31, 2020 at 04:59:18PM +0100, David Fetter wrote:
> > On Wed, Jan 15, 2020 at 03:45:12PM -0800, Jesse Zhang wrote:
> > > On Tue, Jan 14, 2020 at 2:09 PM David Fetter <david(at)fetter(dot)org> wrote:
> > > > > The changes in hash AM and SIMPLEHASH do look like a net positive
> > > > > improvement. My biggest cringe might be in pg_bitutils:
> > > > >
> > > > > 1. Is ceil_log2_64 dead code?
> > > >
> > > > Let's call it nascent code. I suspect there are places it could go, if
> > > > I look for them. Also, it seemed silly to have one without the other.
> > > >
> > >
> > > While not absolutely required, I'd like us to find at least one
> > > place and start using it. (Clang also nags at me when we have
> > > unused functions).
> > Done in the expanded patches attached.
> These bit-rotted a little, so I've updated them.
05d8449e73694585b59f8b03aaa087f04cc4679a broke this patch set, so fix.
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
|Next Message||Kyotaro Horiguchi||2020-02-27 05:57:07||Re: Allow auto_explain to log plans before queries are executed|
|Previous Message||Yugo NAGATA||2020-02-27 05:48:05||Re: Allow auto_explain to log plans before queries are executed|