From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Jesse Zhang <sbjesse(at)gmail(dot)com> |
Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Use compiler intrinsics for bit ops in hash |
Date: | 2020-02-26 08:12:24 |
Message-ID: | 20200226081223.GI13804@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 31, 2020 at 04:59:18PM +0100, David Fetter wrote:
> On Wed, Jan 15, 2020 at 03:45:12PM -0800, Jesse Zhang wrote:
> > On Tue, Jan 14, 2020 at 2:09 PM David Fetter <david(at)fetter(dot)org> wrote:
> > > > The changes in hash AM and SIMPLEHASH do look like a net positive
> > > > improvement. My biggest cringe might be in pg_bitutils:
> > > >
> > > > 1. Is ceil_log2_64 dead code?
> > >
> > > Let's call it nascent code. I suspect there are places it could go, if
> > > I look for them. Also, it seemed silly to have one without the other.
> > >
> >
> > While not absolutely required, I'd like us to find at least one
> > place and start using it. (Clang also nags at me when we have
> > unused functions).
>
> Done in the expanded patches attached.
These bit-rotted a little, so I've updated them.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Attachment | Content-Type | Size |
---|---|---|
v5-0001-de-long-ify.patch | text/x-diff | 56.7 KB |
v5-0002-Spread-bitutils-into-hashing.patch | text/x-diff | 11.4 KB |
v5-0003-Reduced-operations-in-floor_log2.patch | text/x-diff | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Banck | 2020-02-26 08:15:26 | Re: Commit fest manager for 2020-03 |
Previous Message | Sandro Santilli | 2020-02-26 08:11:21 | Re: Marking some contrib modules as trusted extensions |