Re: client-side fsync() error handling

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: client-side fsync() error handling
Date: 2020-02-21 04:18:00
Message-ID: 20200221041800.GC3260@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 20, 2020 at 10:10:11AM +0100, Peter Eisentraut wrote:
> OK, added in new patch.

Thanks, that looks good.

> The frontends do neither right now, or at least the error handling is very
> inconsistent and inscrutable. It would be possible in theory to add a retry
> option, but that would be a very different patch, and given what we have
> learned about fsync(), it probably wouldn't be widely useful.

Perhaps. Let's have this discussion later if there are drawbacks
about changing things the way your patch does. If we don't do that,
we'll never know about it either and this patch makes things safer.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-02-21 04:30:07 Re: pgsql: Add kqueue(2) support to the WaitEventSet API.
Previous Message Michael Paquier 2020-02-21 04:00:01 Re: allow running parts of src/tools/msvc/ under not Windows