|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>|
|Subject:||Re: Clean up some old cruft related to Windows|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Thu, Dec 19, 2019 at 01:46:33PM +0900, Kyotaro Horiguchi wrote:
> I found some similar places by grep'ing for windows version names the
> whole source tree.
> - The comment for trapsig is mentioning win98/Me/NT/2000/XP.
Let's refresh the comment here, as per the following:
> - We don't need the (only) caller site of IsWindows7OrGreater()?
The compiled code can still run with Windows Server 2008.
> - The comment for AddUserToTokenDacl() is mentioning "XP/2K3,
Keeping some context is still good here IMO.
> - InitializeLDAPConnection dynamically loads WLDAP32.DLL for Windows
> 2000. It could either be statically loaded or could be left as it
> is, but the comment seems to need a change in either case.
Looks safer to me to keep it.
> - The comment for IsoLocaleName mentioning Vista and Visual Studio
It is good to keep some history in this context.
> - install-windows.sgml is mentioning "XP and later" around line 117.
But this still applies to XP, even if compilation is supported from
> - installation.sgml is mentioning NT/2000/XP as platforms that don't
> support adduser/su, command.
No objections to simplify that a bit.
Attached is a simplified version. It is smaller than the previous
one, but that's already a good cut. I have also done some testing
with the service manager to check after pipe_read_line(), and that
|Next Message||Amit Langote||2020-02-18 07:53:04||Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side|
|Previous Message||Fujii Masao||2020-02-18 07:42:48||Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side|