| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | False failure during repeated windows build. |
| Date: | 2020-02-18 07:05:00 |
| Message-ID: | 20200218.160500.44393633318853097.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
I found it quite annoying that it stops with complaining as "unused
defines" during repeated execution of build.pl. The subroutine
GenerateConfigHeader prepares %defines_copy before checking the
newness of $config_header and even if it decides not to generate new
one, the following code makes sure if the %defines_copy is empty, then
of course it fails with the message.
The attached fixes that.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-behavior-for-repeated-build-on-Windows.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ants Aasma | 2020-02-18 07:13:45 | Re: Parallel copy |
| Previous Message | Amit Langote | 2020-02-18 07:02:52 | Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |