Re: allow running parts of src/tools/msvc/ under not Windows

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow running parts of src/tools/msvc/ under not Windows
Date: 2020-02-13 13:40:32
Message-ID: 20200213134032.GB15600@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 13, 2020 at 02:24:43PM +0100, Peter Eisentraut wrote:
> On 2020-02-13 13:04, Michael Paquier wrote:
> > On Thu, Feb 13, 2020 at 12:00:54PM +0100, Peter Eisentraut wrote:
> > > When making build system changes that risk breaking the MSVC build system,
> > > it's useful to be able to run the part of the MSVC build tools that read the
> > > makefiles and produce the project files under a not-Windows platform. This
> > > part does not really depend on anything particular to Windows, so it's
> > > possible in principle. There are some minor dependencies on Windows,
> > > however, that need to be worked around. I have had some local hacks for that
> > > for a while, and I took a moment to clean them up and make them presentable,
> > > so here they are. Interested?
> > >
> > > To test, apply the patch and run perl src/tools/msvc/mkvcbuild.pl .
> >
> > $ perl src/tools/msvc/mkvcbuild.pl .
> > Warning: no config.pl found, using default.
> > Unable to determine Visual Studio version: The nmake command wasn't
> > found. at /home/ioltas/git/postgres/src/tools/msvc/Mkvcbuild.pm line 92.
> > Is that the expected result?
>
> No, I had apparently created by own fake "nmake" shell script some time ago
> to work around that. Here is a new patch with that taken care of, too.

With v2 I'm able to successfully run mkvcbuild.pl on linux and macos. I don't
have any knowledge on compiling with windows, so I can't really judge what it's
been doing.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-02-13 14:16:57 Fix compiler warnings on 64-bit Windows
Previous Message Peter Eisentraut 2020-02-13 13:39:41 Re: Optimize update of tables with generated columns