| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: assert pg_class.relnatts is consistent |
| Date: | 2020-02-13 08:10:12 |
| Message-ID: | 20200213081012.GK1520@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 13, 2020 at 04:51:01PM +0900, Amit Langote wrote:
> I would think the answer to that would be related to the answer of why
> you think we need this assert in the first place?
Taking this thread independently, and even after reading the thread
mentioned upthread, I still don't quite understand why this change
could be a good thing and in which cases it actually helps. The code
includes no comments and the commit log says nothing either, so it is
hard to follow what you are thinking here even if you are splitting
the effort across multiple thread. Please note that the style of the
code is not project-like, so you should try to indent it. And why
does it matter to check this portion of the catalogs? Also, such
checks are not really needed in non-assert builds, if actually
needed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-02-13 08:11:45 | Re: assert pg_class.relnatts is consistent |
| Previous Message | Amit Langote | 2020-02-13 07:51:01 | Re: assert pg_class.relnatts is consistent |