| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Getting rid of some more lseek() calls |
| Date: | 2020-02-12 16:30:25 |
| Message-ID: | 20200212163025.GA8864@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Feb-12, Thomas Munro wrote:
> Hmm. Well, on Unix we have to choose between "tell me the size but
> also change the position that I either don't care about or have to
> undo", and "tell me the size but also tell me all this other stuff I
> don't care about". Since Windows apparently has GetFileSizeEx(), why
> not use that when that's exactly what you want? It apparently
> understands large files.
I was already thinking that it might be better to make the new function
just "tell me the file size" without leaking the details of *how* we do
it, before reading about this Windows call. That reinforces it, IMO.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-02-12 16:53:49 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |
| Previous Message | Juan José Santamaría Flecha | 2020-02-12 16:25:15 | Re: Just for fun: Postgres 20? |