Re: pgsql: Test additional speculative conflict scenarios.

Hi,

On 2020-02-12 14:07:17 +0900, Michael Paquier wrote:
> On Wed, Feb 12, 2020 at 12:43:09AM +0000, Andres Freund wrote:
> > Test additional speculative conflict scenarios.
> >
> > Previously, the speculative insert tests did not cover the case when a
> > tuple t is inserted into a table with a unique index on a column but
> > before it can insert into the index, a concurrent transaction has
> > inserted a conflicting value into the index and the insertion of tuple t
> > must be aborted.
>
> guaibasaurus is unhappy after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus&dt=2020-02-12%2004%3A17%3A03
>
> Here is the culprit diff:
> application_namelocktype mode granted
>
> + transactionid ExclusiveLock t
> isolation/insert-conflict-specconflict-s1speculative tokenShareLock f
> isolation/insert-conflict-specconflict-s1transactionid ExclusiveLock t
> isolation/insert-conflict-specconflict-s2speculative tokenExclusiveLock t

Yea, working on the fix already (just restricting application name to
'isolation/insert-conflict-specconflict-s%').

Greetings,

Andres Freund