| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Expose lock group leader pid in pg_stat_activity |
| Date: | 2020-02-05 06:57:20 |
| Message-ID: | 20200205065720.GA31242@nol |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 05, 2020 at 10:48:31AM +0900, Michael Paquier wrote:
> On Tue, Feb 04, 2020 at 03:27:25PM +0100, Julien Rouhaud wrote:
> > I added some code comments to remind that we don't guarantee any consistency
> > here.
>
> That's mostly fine. I have moved the comment related to
> AuxiliaryPidGetProc() within the inner part of its the "if" (or the
> comment should be changed to be conditional). An extra thing is that
> nulls[29] was not set to true for a user without the proper permission
> rights.
Oh, oops indeed.
> Does that look fine to you?
This looks good, thanks a lot!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kasahara Tatsuhito | 2020-02-05 07:25:25 | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |
| Previous Message | Amit Langote | 2020-02-05 06:53:45 | Re: ALTER tbl rewrite loses CLUSTER ON index |