| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Expose lock group leader pid in pg_stat_activity |
| Date: | 2020-02-05 01:48:31 |
| Message-ID: | 20200205014831.GC23913@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 04, 2020 at 03:27:25PM +0100, Julien Rouhaud wrote:
> I added some code comments to remind that we don't guarantee any consistency
> here.
That's mostly fine. I have moved the comment related to
AuxiliaryPidGetProc() within the inner part of its the "if" (or the
comment should be changed to be conditional). An extra thing is that
nulls[29] was not set to true for a user without the proper permission
rights.
Does that look fine to you?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgsa-leader-pid-v6.diff | text/x-diff | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2020-02-05 02:18:52 | Re: Portal->commandTag as an enum |
| Previous Message | tsunakawa.takay@fujitsu.com | 2020-02-05 00:34:19 | RE: Complete data erasure |