Re: SimpleLruTruncate() mutual exclusion

From: Noah Misch <noah(at)leadboat(dot)com>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: SimpleLruTruncate() mutual exclusion
Date: 2020-01-31 08:42:13
Message-ID: 20200131084213.GC3203372@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 30, 2020 at 04:34:33PM +0100, Dmitry Dolgov wrote:
> > On Sun, Nov 17, 2019 at 10:14:26PM -0800, Noah Misch wrote:
> > > I'm probably missing something, so just wanted to clarify. Do I
> > > understand correctly, that thread [1] and this one are independent, and
> > > it is assumed in the scenario above that we're at the end of XID space,
> > > but not necessarily having rounding issues? I'm a bit confused, since
> > > the reproduce script does something about cutoffPage, and I'm not sure
> > > if it's important or not.
> >
> > I think the repro recipe contained an early fix for the other thread's bug.
> > While they're independent in principle, I likely never reproduced this bug
> > without having a fix in place for the other thread's bug. The bug in the
> > other thread was easier to hit.
>
> Just to clarify, since the CF item for this patch was withdrawn
> recently. Does it mean that eventually the thread [1] covers this one
> too?
>
> [1]: https://www.postgresql.org/message-id/flat/20190202083822.GC32531%40gust.leadboat.com

I withdrew $SUBJECT because, if someone reviews one of my patches, I want it
to be the one you cite in [1]. I plan not to commit [1] without a Ready for
Committer, and I plan not to commit $SUBJECT before committing [1]. I would
be willing to commit $SUBJECT without getting a review, however.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-01-31 09:37:57 Re: Hash join not finding which collation to use for string hashing
Previous Message Kyotaro Horiguchi 2020-01-31 08:39:36 Re: [Patch] Make pg_checksums skip foreign tablespace directories