| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BufFileRead() error signalling |
| Date: | 2020-01-30 05:27:51 |
| Message-ID: | 20200130052751.GD1956@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 29, 2020 at 10:01:31AM -0500, Robert Haas wrote:
> Your grep misses one instance of 'read only %d of %d bytes' because
> you grepped for %zu specifically, but that doesn't really change the
> overall picture.
Yes, the one in pg_checksums.c. That could actually be changed with a
cast to Size. (Note that there is a second one related to writes but
there is a precedent in md.c, and a similar one in rewriteheap.c..)
Sorry for the digression.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Barwick | 2020-01-30 05:29:06 | Prevent pg_basebackup running as root |
| Previous Message | Kyotaro Horiguchi | 2020-01-30 04:48:38 | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |