Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits
Date: 2020-01-23 06:57:56
Message-ID: 20200123065756.GC1895@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 22, 2020 at 02:34:57PM +0900, Michael Paquier wrote:
> Shouldn't the last part of the sentence be "we should mark it so"
> instead of "we should so mark it"? I would rephrase the whole as
> follows:
> "If the all-visible page is all-frozen but not marked as such yet,
> mark it as all-frozen."

Applied this one to HEAD after chewing on it a bit.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-01-23 07:04:51 Re: Do we need to handle orphaned prepared transactions in the server?
Previous Message Michael Paquier 2020-01-23 06:30:16 Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?