Re: [PATCH] Windows port, fix some resources leaks

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Windows port, fix some resources leaks
Date: 2020-01-22 06:12:32
Message-ID: 20200122061232.GI174860@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 21, 2020 at 11:01:07AM -0300, Ranier Vilela wrote:
> Done.

I would recommend that you also run all the regression tests present
in the source before sending a patch. If you don't know how to do
that, there is some documentation on the matter:
https://www.postgresql.org/docs/current/regress-run.html

If you send any patches, it is always important to make sure that
nothing you change breaks the existing coverage (on top of reading the
surrounding code and understanding its context, of course)

Hint: this crashes at initdb time.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 曾文旌 (义从) 2020-01-22 06:16:10 Re: [Proposal] Global temporary tables
Previous Message Amit Langote 2020-01-22 06:06:52 Re: progress report for ANALYZE