| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Thunder <thunder1(at)126(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PATCH: standby crashed when replay block which truncated in standby but failed to truncate in master node |
| Date: | 2020-01-17 04:47:01 |
| Message-ID: | 20200117044701.GH2127@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 16, 2020 at 11:17:36PM +0900, Fujii Masao wrote:
> OK, I updated the patch that way.
> Attached is the updated version of the patch.
Thanks. I have few tweaks to propose to the docs.
+ raise a PANIC-level error, aborting the recovery. Setting
Instead of "PANIC-level error", I would just use "PANIC error", and
instead of "aborting the recovery" just "crashing the server".
+ causes the system to ignore those WAL records
WAL records are not ignored, but errors caused by incorrect page
references in those WAL records are. The current phrasing sounds like
the WAL records are not applied.
Another thing that I just recalled. Do you think that it would be
better to mention that invalid page references can only be seen after
reaching the consistent point during recovery? The information given
looks enough, but I was just wondering if that's worth documenting or
not.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-17 05:13:49 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Michael Paquier | 2020-01-17 04:36:52 | Re: Add pg_file_sync() to adminpack |