| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH v1] pg_ls_tmpdir to show directories |
| Date: | 2020-01-16 00:39:24 |
| Message-ID: | 20200116003924.GJ26045@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 15, 2020 at 11:21:36AM +0100, Fabien COELHO wrote:
> I'm trying to think about how to get rid of the strange structure and hacks,
> and the arbitrary looking size 2 array.
>
> Also the recursion is one step, but I'm not sure why, ISTM it could/should
> go on always?
Because tmpfiles only go one level deep.
> Looking at the code, ISTM that relying on a stack/list would be much cleaner
> and easier to understand. The code could look like:
I'm willing to change the implementation, but only after there's an agreement
about the desired behavior (extra column, one level, etc).
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-01-16 01:00:52 | Re: Improve errors when setting incorrect bounds for SSL protocols |
| Previous Message | Jesse Zhang | 2020-01-15 23:45:12 | Re: Use compiler intrinsics for bit ops in hash |