| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Luis Carril <luis(dot)carril(at)swarm64(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: Add FOREIGN to ALTER TABLE in pg_dump |
| Date: | 2020-01-14 23:04:11 |
| Message-ID: | 20200114230411.GA10233@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jan-14, Tom Lane wrote:
> I can't get terribly excited about persuading that test to cover this
> trivial little bit of logic, but if you are, I won't stand in the way.
Hmm, that's a good point actually: the patch changed several places to
inject the FOREIGN keyword, so in order to cover them all it would need
several additional regexps, not just one. I'm not sure that
002_pg_dump.pl is prepared to do that without unsightly contortions.
Anyway, other than that minor omission the patch seemed good to me, so I
don't oppose Tomas pushing the version I posted yesterday. Or I can, if
he prefers that.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-01-14 23:04:29 | Re: Unicode escapes with any backend encoding |
| Previous Message | Tom Lane | 2020-01-14 23:03:39 | Re: Avoid full GIN index scan when possible |