Re: libpq parameter parsing problem

On Mon, Jan 13, 2020 at 08:07:06PM +0530, Jobin Augustine wrote:
> Sorry for the late reply. Attaching a patch.

> <para>
> - Percent-encoding may be used to include symbols with special meaning in any
> - of the <acronym>URI</acronym> parts, e.g. replace <literal>=</literal> with
> - <literal>%3D</literal>.
> -
> + Connection <acronym>URI</acronym> need to be encoded with
> + <ulink url="https://en.wikipedia.org/wiki/Percent-encoding">Percent-encoding</ulink>
> + if it includes symbols with special meaning in any of its parts.
> + For example:
> +<programlisting>
> +postgresql://postgres(at)localhost:5432/postgres?options=-c%20synchronous_commit%3Doff%20-c%20geqo%3Doff
> +</programlisting>
> + where all <literal>=</literal> are replaced with <literal>%3D</literal> and
> + space character with <literal>%20</literal>
> </para>

The reference to wikipedia is nice to have. A small nit from me is
that I would group the last sentence with the "For example", to give:
"Here is an example where all = are replaced.."

The first sentence sounds good to me.
--
Michael